Convert toString() to getMessage() for InvalidGlobPatternException

Also changes `PackageFactoryTest#testBadCharacterInGlob(.)` expected error message to reflect the new behavior. PiperOrigin-RevId: 593865516 Change-Id: Ie99ff88aea6528fb3adc3670af1602ea9a3d6ce4
fmeum · Dec 26, 2023 · 673d4d3 · 673d4d3
1 parent 743e24b
commit 673d4d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/InvalidGlobPatternException.java b/src/main/java/com/google/devtools/build/lib/skyframe/InvalidGlobPatternException.java
@@ -26,7 +26,7 @@ public final class InvalidGlobPatternException extends Exception {
   }
 
   @Override
-  public String toString() {
-    return String.format("invalid glob pattern '%s': %s", pattern, getMessage());
+  public String getMessage() {
+    return String.format("invalid glob pattern '%s': %s", pattern, super.getMessage());
   }
 }
diff --git a/src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java b/src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java
@@ -727,7 +727,7 @@ public void testGlobWithSubdirMatchAndExclusion() throws Exception {
   @Test
   public void testBadCharacterInGlob() throws Exception {
     reporter.removeHandler(failFastHandler);
-    assertGlobFails("glob(['?'])", "Error in glob: wildcard ? forbidden");
+    assertGlobFails("glob(['?'])", "Error in glob: invalid glob pattern '?': wildcard ? forbidden");
   }
 
   @Test