Skip to content

Commit

Permalink
Exempt password managers from the Uphold content script restrictions
Browse files Browse the repository at this point in the history
This should mitigate some of the bad UX described in
brave/brave-browser#6309.
  • Loading branch information
fmarier committed Oct 11, 2019
1 parent 495d1a9 commit 0831948
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions chromium_src/extensions/common/permissions/permissions_data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,26 @@

namespace extensions {

const char k1PasswordId[] = "aomjjhallfgjeglblehebfpbcfeobpgk";
const char k1PasswordXId[] = "aeblfdkhhhdcdjpifhhbdiojplfjncoa";
const char kBitWardenId[] = "nngceckbapebfimnlniiiahkandclblb";
const char kDashlaneId[] = "fdjamakpfbbddfjaooikfcpapjohcfmg";
const char kKeePassXCId[] = "oboonakemofpalcgghocfoadofidjkkk";
const char kKeeperId[] = "bfogiafebfohielmmehodmfbbebbbpei";
const char kLastPassId[] = "hdokiejnpimakedhajhdlcegeplioahd";
const char kPainFreePasswordsId[] = "hplhaekjfmjfnfdllkpjpeenlbclffgh";
const char kRoboFormId[] = "pnlccmojcmeohlpggmfnbbiapkmbliob";

bool IsKnownPasswordManagerExtension(
const extensions::ExtensionId& extension_id) {
return (extension_id == k1PasswordId) || (extension_id == k1PasswordXId) ||
(extension_id == kBitWardenId) || (extension_id == kDashlaneId) ||
(extension_id == kKeePassXCId) || (extension_id == kKeeperId) ||
(extension_id == kLastPassId) ||
(extension_id == kPainFreePasswordsId) ||
(extension_id == kRoboFormId);
}

bool IsBraveProtectedUrl(const GURL& url) {
const url::Origin origin = url::Origin::Create(url);
const base::StringPiece path = url.path_piece();
Expand Down Expand Up @@ -39,6 +59,10 @@ bool IsBraveRestrictedUrl(const GURL& document_url,
return false;
}

if (extensions::IsKnownPasswordManagerExtension(extension_id)) {
return false;
}

if (extensions::IsBraveProtectedUrl(document_url)) {
if (error) {
*error = kCannotScriptWalletLinking;
Expand Down

0 comments on commit 0831948

Please sign in to comment.