Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

hotfix for stow config #97

Merged
merged 1 commit into from
Aug 21, 2021
Merged

hotfix for stow config #97

merged 1 commit into from
Aug 21, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Aug 21, 2021

TL;DR

Bug :-

Is not working as expected 
if  !reflect.DeepEqual(cfg.Stow, StowConfig{}) {

}

Solution :

if  len(cfg.Stow.Kind) > 0 && len(cfg.Stow.Config) > 0  {

}

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #97 (081a2f5) into master (f6f76d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files          59       59           
  Lines        2824     2824           
=======================================
  Hits         1885     1885           
  Misses        794      794           
  Partials      145      145           
Flag Coverage Δ
unittests 65.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/stow_store.go 73.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f76d8...081a2f5. Read the comment docs.

@yindia yindia merged commit 3191899 into master Aug 21, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants