This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
stdlibConfig strictMode should not fail if there are existing flags #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 65.49% 65.19% -0.31%
==========================================
Files 59 59
Lines 2275 2284 +9
==========================================
- Hits 1490 1489 -1
- Misses 642 652 +10
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
requested review from
pmahindrakar-oss
and removed request for
katrogan and
kumare3
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
approved these changes
Jul 7, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
) * Do not error on existing flags Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update unit test Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update
strictModeto capture existing flags in a flagset before parsing params. This way it can avoid failing when there are flags defined outside of stdlibConfig world.Type
Are all requirements met?
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#1209