This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
NewSummary functions with Custom Objectives #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnsblue
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
katrogan
reviewed
Jan 27, 2020
promutils/scope.go
Outdated
| @@ -133,6 +133,11 @@ type Scope interface { | |||
| NewSummary(name, description string) (prometheus.Summary, error) | |||
| MustNewSummary(name, description string) prometheus.Summary | |||
|
|
|||
| // Creates new prometheus.Summary metric with a custom set of objectives | |||
There was a problem hiding this comment.
can you explain what an objective is in this comment? the link doesn't elaborate
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 72.21% 72.11% -0.11%
==========================================
Files 56 56
Lines 2246 2252 +6
==========================================
+ Hits 1622 1624 +2
- Misses 500 504 +4
Partials 124 124
Continue to review full report at Codecov.
|
EngHabu
previously approved these changes
Jan 27, 2020
katrogan
previously approved these changes
Jan 27, 2020
katrogan
approved these changes
Jan 27, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* upgrade dependency, and add new summary creation function that takes custom objectives * fix test * refactor the newly added functions * add what objectives mean to the comments * add comments to SummaryOptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.