This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
incorporate latest boilerplate changes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 72.21% 72.21%
=======================================
Files 56 56
Lines 2242 2242
=======================================
Hits 1619 1619
Misses 500 500
Partials 123 123Continue to review full report at Codecov.
|
…to update-boilerplate
This reverts commit ce65baa.
honnix
commented
Jan 21, 2020
| @@ -22,7 +22,6 @@ go_install_tool () { | |||
| # List of tools to go get | |||
| # In the format of "<cli>:<package>" or ":<package>" if no cli | |||
| tools=( | |||
| "pflags:github.com/lyft/flytestdlib/cli/pflags" | |||
There was a problem hiding this comment.
This doesn't work. I guess due to the funky dependency of itself.
EngHabu
reviewed
Jan 21, 2020
honnix
force-pushed
the
update-boilerplate
branch
from
6fe2ce6 to
f11b511
Compare
|
Not sure |
|
@wild-endeavor PTAL |
wild-endeavor
approved these changes
Jan 24, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
This reflects changes done in flyteorg/boilerplate#4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects changes done in flyteorg/boilerplate#4