This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Set provider only if all methods are implemented #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
EngHabu
approved these changes
Jul 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 70.34% 70.37% +0.02%
==========================================
Files 51 51
Lines 1831 1836 +5
==========================================
+ Hits 1288 1292 +4
Misses 429 429
- Partials 114 115 +1
Continue to review full report at Codecov.
|
EngHabu
reviewed
Jul 2, 2019
| var provider interface{} //nolint | ||
| provider = prometheusMetricsProvider{} | ||
| if p, casted := provider.(workqueue.MetricsProvider); casted { | ||
| workqueue.SetProvider(p) |
There was a problem hiding this comment.
Can you log a warning in the else clause?
EngHabu
approved these changes
Jul 2, 2019
EngHabu
approved these changes
Jul 2, 2019
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Set provider only if all methods of interface are implemented
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface workqueue.MetricsProvider has backward incompatible interface in the newer versions of Client Go.
Until we permanently upgrade Flytestdlib to the new interface, a temp fix to make Flytestdlib work with newer versions of client-go