This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add lp as an optional label for stats #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewphsmith
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
|
PTAL @wild-endeavor @EngHabu |
|
LGTM but not sure if launch plan keys are too specific for stdlib? |
… effects of that would be based on ordering of tests
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 70.37% 70.49% +0.12%
==========================================
Files 51 51
Lines 1836 1844 +8
==========================================
+ Hits 1292 1300 +8
Misses 429 429
Partials 115 115
Continue to review full report at Codecov.
|
|
🚀 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add lp as an optional label for stats * goimports * Add lp as log key * Allow for testing of singleton metric keys * remove init() function from test package since it is unclear what the effects of that would be based on ordering of tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In building alarms and graphs on executions, it is not currently possible to different between executions started by different launch plans. This is problematic for us in our functional tests because the launch plan ID is what differentiates beta and prod executions. Likewise, this would make it difficult/impossible for users to alert on parameterized scheduled workflows.
This adds the necessary label context utils which will be used to set the launch plan context by Propeller.