This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Flinkk8soperator needs Log writer to be passed to Resty #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 71.12% 71.06% -0.06%
==========================================
Files 51 51
Lines 1811 1818 +7
==========================================
+ Hits 1288 1292 +4
- Misses 409 412 +3
Partials 114 114
Continue to review full report at Codecov.
|
EngHabu
approved these changes
Jun 11, 2019
EngHabu
reviewed
Jun 11, 2019
| @@ -81,6 +82,11 @@ func getLogger(ctx context.Context) logrus.FieldLogger { | |||
| return entry | |||
| } | |||
|
|
|||
| func GetLogWriter(ctx context.Context) *io.PipeWriter { | |||
EngHabu
reviewed
Jun 11, 2019
Co-Authored-By: Haytham AbuelFutuh <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Flinkk8soperator needs Log writer to be passed to
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink operator uses https://github.com/go-resty/resty to communicate to Job manager. Resty call logs do not follow the logger settings.
If flytestdlib logger can expose writer, I can pass it in to resty.SetLogger(..)
Alternatively we can expose GetLogger if you think that is better.