This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Stow head etag #160
Merged
Stow head etag #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
8 tasks
wild-endeavor
previously approved these changes
Jul 10, 2023
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
previously approved these changes
Jul 10, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
approved these changes
Jul 10, 2023
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Implement Etag() in storage layer Signed-off-by: Haytham Abuelfutuh <[email protected]> * go mod tidy Signed-off-by: Haytham Abuelfutuh <[email protected]> * Actually propagating etag Signed-off-by: Haytham Abuelfutuh <[email protected]> * Implement UnionMeta store Signed-off-by: Haytham Abuelfutuh <[email protected]> * Allow registeration of additional stow stores Signed-off-by: Haytham Abuelfutuh <[email protected]> * Support grpc NotFound in IsNotFound() Signed-off-by: Haytham Abuelfutuh <[email protected]> * correct error code check Signed-off-by: Haytham Abuelfutuh <[email protected]> * Cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * more cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Feedback Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint and nits Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Support returning ETag for in Metadata responses.
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#3856