Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated integrations docs and clean up code files #1655

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 22, 2024

Moves deprecated integrations docs to flyte and removes Markdown comments from code files.

Merge flyteorg/flyte#5267 first, then merge this PR.

nikki everett added 4 commits April 23, 2024 11:39
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett changed the title [WIP] Move deprecated integrations docs and clean up code files Move deprecated integrations docs and clean up code files Apr 23, 2024
@neverett neverett marked this pull request as ready for review April 23, 2024 18:50
@neverett neverett requested a review from ppiegaze as a code owner April 23, 2024 18:50
@neverett
Copy link
Contributor Author

neverett commented Apr 23, 2024

The monodocs build failure here is because the docs index file in the flyte repo references a doc that was deleted by this PR. Once flyteorg/flyte#5267 is merged, the monodocs build for this PR should succeed.

@neverett neverett merged commit 9bbf486 into master Apr 25, 2024
98 checks passed
@neverett neverett deleted the nikki/clean-deprecated-integrations branch April 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants