Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Merge branch 'master' into lazy_load
Browse files Browse the repository at this point in the history
  • Loading branch information
pingsutw authored Jun 7, 2023
2 parents 52ee874 + c61fa47 commit c66ad89
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/compiler/transformers/k8s/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ func StripTypeMetadata(t *core.LiteralType) *core.LiteralType {

c := *t
c.Metadata = nil
c.Structure = nil
c.Annotation = nil
// Note that we cannot strip `Structure` from the type because the dynamic node output type is used to validate the
// interface of the dynamically compiled workflow. `Structure` is used to extend type checking information on
// differnent Flyte types and is therefore required to ensure correct type validation.

switch underlyingType := c.Type.(type) {
case *core.LiteralType_UnionType:
Expand Down
1 change: 1 addition & 0 deletions pkg/compiler/transformers/k8s/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ func TestStripTypeMetadata(t *testing.T) {
Type: &core.LiteralType_Simple{
Simple: core.SimpleType_STRING,
},
Structure: &core.TypeStructure{Tag: "str"},
},
},
},
Expand Down

0 comments on commit c66ad89

Please sign in to comment.