This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Lazy load gRPC plugin #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 62.77% 64.19% +1.41%
==========================================
Files 148 148
Lines 12664 10286 -2378
==========================================
- Hits 7950 6603 -1347
+ Misses 4105 3072 -1033
- Partials 609 611 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hamersaw
previously approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, this is the cleanest way to handle this.
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
hamersaw
previously approved these changes
May 30, 2023
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
hamersaw
reviewed
Jun 5, 2023
@@ -8,6 +8,8 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to make alphabetical?
Signed-off-by: Kevin Su <[email protected]>
hamersaw
approved these changes
Jun 5, 2023
11 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Lazy load grpc plugin Signed-off-by: Kevin Su <[email protected]> * rename Signed-off-by: Kevin Su <[email protected]> * rename Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * rename Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Related to flyteorg/flytepropeller#564
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA