Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore tests on windows #967

Merged
merged 26 commits into from
Apr 21, 2022
Merged

Fix ignore tests on windows #967

merged 26 commits into from
Apr 21, 2022

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Apr 21, 2022

TL;DR

Stacked PR on top of #899 to fix unit tests failures on windows

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1437

bimtauer and others added 25 commits April 6, 2022 15:41
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Tim Bauer <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #967 (3f112e6) into master (7a7d723) will increase coverage by 0.23%.
The diff coverage is 95.48%.

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   85.96%   86.20%   +0.23%     
==========================================
  Files         248      250       +2     
  Lines       23671    23914     +243     
  Branches     2678     2706      +28     
==========================================
+ Hits        20349    20614     +265     
+ Misses       2873     2849      -24     
- Partials      449      451       +2     
Impacted Files Coverage Δ
flytekit/tools/repo.py 46.03% <0.00%> (+1.25%) ⬆️
flytekit/clis/sdk_in_container/serialize.py 56.52% <33.33%> (+1.85%) ⬆️
flytekit/tools/ignore.py 90.69% <90.69%> (ø)
flytekit/tools/fast_registration.py 84.90% <92.68%> (+41.26%) ⬆️
...ests/flytekit/unit/tools/test_fast_registration.py 100.00% <100.00%> (ø)
tests/flytekit/unit/tools/test_ignore.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7d723...3f112e6. Read the comment docs.

@kumare3
Copy link
Contributor

kumare3 commented Apr 21, 2022

security tests seem to have passed.

@kumare3
Copy link
Contributor

kumare3 commented Apr 21, 2022

@bimtauer we are merging this change, sorry, but to fix we had to create a new PR.

@kumare3 kumare3 merged commit 8e8d08c into master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants