Turn on StructuredDataset #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 86.47% 86.49% +0.01%
==========================================
Files 230 230
Lines 22078 22065 -13
Branches 2459 2456 -3
==========================================
- Hits 19093 19086 -7
+ Misses 2578 2575 -3
+ Partials 407 404 -3
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
Mar 11, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
|
@eapolinario had to fix a lint. +1? |
Is paper mill broken? |
kumare3
approved these changes
Mar 12, 2022
|
@kumare3 , nbclient, one of the dependencies of the papermill plug-in is broken and it's being tracked in jupyter/nbclient#207. |
myz540
pushed a commit
to ProjectAussie/flytekit
that referenced
this pull request
Apr 11, 2022
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Mike Zhong <[email protected]>
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong [email protected]
TL;DR
Remove the feature gate for StructuredDataset. This means that by default
pd.DataFramewill resolve to Flyte IDL's StructuredDataset type/literal instead of FlyteSchema.See the original PR #785
Note:
If you are seeing compilation errors, please make sure you're on Propeller version v0.16.14 and Admin version v0.6.78 or later.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/