Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete CI for integration tests for now #884

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Mar 10, 2022

Signed-off-by: Yee Hing Tong [email protected]

TL;DR

Stop running integration tests for now. The pytest-flyte framework needs to be updated to reflect the new config system. Should be a minor change but we've been hoping to swap out the docker-compose backend with just flytectl sandbox for a while.

Type

  • Bug Fix
  • Feature
  • Plugin

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title delete ci for integration tests Delete CI for integration tests for now Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #884 (9bc9da2) into master (457f323) will decrease coverage by 0.94%.
The diff coverage is 81.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   87.42%   86.47%   -0.95%     
==========================================
  Files         248      230      -18     
  Lines       22555    22078     -477     
  Branches     2517     2459      -58     
==========================================
- Hits        19719    19093     -626     
- Misses       2405     2578     +173     
+ Partials      431      407      -24     
Impacted Files Coverage Δ
tests/flytekit/unit/cli/test_flyte_cli.py 100.00% <ø> (ø)
flytekit/remote/remote.py 40.78% <29.03%> (-26.80%) ⬇️
flytekit/clis/sdk_in_container/serialize.py 50.58% <30.76%> (-6.21%) ⬇️
flytekit/clis/flyte_cli/main.py 44.33% <32.65%> (-1.99%) ⬇️
flytekit/types/structured/structured_dataset.py 93.45% <33.33%> (ø)
flytekit/clis/sdk_in_container/pyflyte.py 67.64% <36.36%> (-6.83%) ⬇️
flytekit/core/launch_plan.py 94.92% <50.00%> (-0.67%) ⬇️
flytekit/types/structured/__init__.py 62.50% <50.00%> (ø)
flytekit/clients/raw.py 66.78% <51.94%> (-8.22%) ⬇️
flytekit/extras/persistence/s3_awscli.py 81.03% <58.33%> (-7.15%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca5607...9bc9da2. Read the comment docs.

@wild-endeavor wild-endeavor merged commit 2946952 into master Mar 10, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Mike Zhong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants