GH-5989: Fix task registration with node_dependency_hints
#2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Tom-Newton
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2992 +/- ##
==========================================
- Coverage 51.51% 46.78% -4.73%
==========================================
Files 203 200 -3
Lines 21199 20950 -249
Branches 2707 2708 +1
==========================================
- Hits 10920 9802 -1118
- Misses 9688 10663 +975
+ Partials 591 485 -106 ☔ View full report in Codecov by Sentry. |
|
Hmm.... looks like my test is failing on CI, I'll investigate shortly. |
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Tom-Newton
force-pushed
the
tomnewton/fix_task_registration_with_node_dependency_hints/GH-5989
branch
from
b3071b8 to
3efd4ea
Compare
Signed-off-by: Thomas Newton <[email protected]>
Tom-Newton
commented
Dec 9, 2024
Comment on lines
+527
to
+529
| flyte_workflow = FlyteWorkflow.promote_from_closure(compiled_wf, node_launch_plans) | ||
| flyte_workflow.template._id = workflow_id | ||
| return flyte_workflow |
There was a problem hiding this comment.
This bit isn't necessary, but it looks like tasks already do this and it makes it easier to unittest.
eapolinario
approved these changes
Dec 11, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5989
Why are the changes needed?
To fix directly registering tasks that use
node_dependency_hintspointing to a workflow.What changes were proposed in this pull request?
Make
FlyteRemote._serialize_and_registeralways return the remote version of the providedentityregardless of whether it happens to be the last entity to be registered.How was this patch tested?
Wrote a new unittest
Check all the applicable boxes
Related PRs
node_dependency_hintswere introduced by #2015Docs link