Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level access to FlyteRemote, FlyteFile, and FlyteDirectory and convenience class methods for FlyteRemote (#2836) #2904

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

eapolinario
Copy link
Collaborator

Backport #2836

…d convenience class methods for FlyteRemote (#2836)

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.63%. Comparing base (9d52cd1) to head (006c87d).
Report is 3 commits behind head on release-v1.13.

Files with missing lines Patch % Lines
flytekit/remote/remote.py 72.72% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9d52cd1) and HEAD (006c87d). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (9d52cd1) HEAD (006c87d)
10 3
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-v1.13    #2904       +/-   ##
==================================================
- Coverage          93.26%   47.63%   -45.63%     
==================================================
  Files                 54      194      +140     
  Lines               2689    19906    +17217     
  Branches               0     2538     +2538     
==================================================
+ Hits                2508     9483     +6975     
- Misses               181     9930     +9749     
- Partials               0      493      +493     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 61c066c into release-v1.13 Nov 5, 2024
103 of 105 checks passed
@eapolinario eapolinario deleted the backport-2898-to-release-v1.13 branch November 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants