Default nb task resolver msg #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
eapolinario
reviewed
Nov 1, 2024
Signed-off-by: Niels Bantilan <[email protected]>
eapolinario
approved these changes
Nov 1, 2024
thomasjpfan
approved these changes
Nov 1, 2024
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
* add additional info to default notebook task resolver Signed-off-by: Niels Bantilan <[email protected]> * add object repr to error message Signed-off-by: Niels Bantilan <[email protected]> * update string Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]>
katrogan
pushed a commit
that referenced
this pull request
Nov 15, 2024
* add additional info to default notebook task resolver Signed-off-by: Niels Bantilan <[email protected]> * add object repr to error message Signed-off-by: Niels Bantilan <[email protected]> * update string Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
It's useful to the know the unpickled object and its type when loading the task with the default notebook task resolver. This just eases the debugging experience.
What changes were proposed in this pull request?
Updates the error message when the unpickled file is of the unexpected type.