-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Integrate with Soda.io #2884
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2884 +/- ##
===========================================
- Coverage 76.79% 40.38% -36.42%
===========================================
Files 196 199 +3
Lines 20546 20781 +235
Branches 2646 2671 +25
===========================================
- Hits 15779 8393 -7386
- Misses 4068 12287 +8219
+ Partials 699 101 -598 ☔ View full report in Codecov by Sentry. |
Hi @kumare3 @wild-endeavor @thomasjpfan @Future-Outlier @eapolinario @pingsutw @samhita-alla @cosmicBboy, I wanted to follow up on this PR, about the basic prototype of this plugin and check if I’m heading in the right direction with the integration. Also had a few questions in mind,
I look forward to your insights and any guidance on improving this PR. Please let me know if I’m on the right track, or if there are areas I should revisit. Thanks again! |
@10sharmashivam thank you. Please notice that recently we merged this RFC. It means that community-contributed plugins should live under |
Hi @davidmirror-ops, thanks for the update! I reviewed the recent RFC regarding community-contributed plugins and the proposed plugins/community structure. Could you confirm if this folder structure is fully implemented and ready for use? Thanks again for your guidance—I’ll proceed based on your input. |
@10sharmashivam the folder is not created yet, waiting for the first contribution after the RFC :) So feel free to create it. Also, please check the lint errors |
@davidmirror-ops Thank you for the clarification! I’ve set up the plugins/community structure and moved the plugin there, following the RFC as discussed. Also, I’ve addressed the linting issues—everything should be in order now. Let me know if there’s anything else you’d like me to adjust. Thanks again! |
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
Signed-off-by: 10sharmashivam <[email protected]>
f204dc6
to
41f4f58
Compare
Tracking issue
Reference Issue - #2963
Why are the changes needed?
The Soda.io plugin integrates data quality monitoring into Flyte, enabling users to automatically perform data quality checks on their datasets. This integration ensures that data quality is maintained throughout workflows, providing users with timely insights into data issues and enhancing the reliability and trustworthiness of their data-driven processes.
What changes were proposed in this pull request?
How was this patch tested?
I tested this basic prototype of the plugin through basic unit tests locally, covering both positive and negative scenarios. The tests ensure that the new functionality works as expected and that any edge cases are handled gracefully.
Additional Comments
I’m submitting this PR as an initial implementation of the Soda.io plugin integration. At this stage, I’ve structured the plugin, created the SodaCheckConfig and SodaCheckTask classes, and registered the plugin with Flyte.
I’d greatly appreciate any feedback or guidance to ensure that I’m on the right track with this implementation. I’ll continue to refine the code and address any changes based on the team’s suggestions and feedback.
Looking forward to your insights!
Check all the applicable boxes
Future Enhancements
Looking ahead, I plan to implement the following enhancements to further improve the plugin:
Please let me know if I chose the correct approach and should continue with this and enhance this plugin!