Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Flytekit README link not working in the File an Issue section #2864

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

400Ping
Copy link
Contributor

@400Ping 400Ping commented Oct 25, 2024

Tracking issue

Related to flyteorg/flyte#5894

Why are the changes needed?

The link here is not working, so I proposed this PR to change it.

What changes were proposed in this pull request?

Change the not working link to this

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flyte#5894

Docs link

Copy link

welcome bot commented Oct 25, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (8017ae8) to head (4243ebe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2864       +/-   ##
===========================================
+ Coverage   45.55%   75.62%   +30.07%     
===========================================
  Files         196      196               
  Lines       20434    20434               
  Branches     2633     2633               
===========================================
+ Hits         9309    15454     +6145     
+ Misses      10676     4220     -6456     
- Partials      449      760      +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier merged commit 57f583e into flyteorg:master Oct 25, 2024
106 checks passed
Copy link

welcome bot commented Oct 25, 2024

Congrats on merging your first pull request! 🎉

@400Ping 400Ping deleted the #5894 branch November 6, 2024 07:41
kumare3 pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants