Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch mistake in structured dataset #2834

Merged
merged 2 commits into from
Oct 18, 2024

add typeengine check as well

8f7035a
Select commit
Loading
Failed to load commit list.
Merged

Catch mistake in structured dataset #2834

add typeengine check as well
8f7035a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 18, 2024 in 0s

74.96% (-20.66%) compared to 194300f

View this Pull Request on Codecov

74.96% (-20.66%) compared to 194300f

Details

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (194300f) to head (8f7035a).

Files with missing lines Patch % Lines
flytekit/types/structured/structured_dataset.py 0.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (194300f) and HEAD (8f7035a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (194300f) HEAD (8f7035a)
5 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2834       +/-   ##
===========================================
- Coverage   95.61%   74.96%   -20.66%     
===========================================
  Files          31      196      +165     
  Lines        1094    20380    +19286     
  Branches        0     2626     +2626     
===========================================
+ Hits         1046    15277    +14231     
- Misses         48     4397     +4349     
- Partials        0      706      +706     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.