Catch all exceptions when rendering python dependencies #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
Future-Outlier
as code owners
pingsutw
approved these changes
Aug 8, 2024
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: mao3267 <[email protected]>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Thomas J. Fan <[email protected]>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Mecoli1219 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to flyteorg/flyte#5618
Why are the changes needed?
I think any execution in the renderer should not crash the execution. With this PR, it will always be caught.
What changes were proposed in this pull request?
With this PR, all exceptions are caught.