Fix overriding of loader_args task resolver in papermill plugin #2660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In #1859 (which was released in flytekitplugins-papermill 1.10.0) we ended up overriding the task resolver's
loader_args
method in order to generate the correctNotebookTask
container arguments. However we never restored that function to its original value, which has the side effect that in the case of shared task resolvers (e.g. thedefault_task_resolver
used for regular tasks) we end up reusing the lastNotebookTask
registered as the task name.What changes were proposed in this pull request?
This PR restores the loader_args in papermill plugin's
get_container
andget_k8s_pod
.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link