Support torch async dist checkpoint #2612
Draft
+64
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novahow
force-pushed
the
plugins/torch_async
branch
2 times, most recently
from
df2c0c4 to
4295a9b
Compare
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]> Revert "exp with union imagespec" This reverts commit c75529e. exp with union imagespec test version Signed-off-by: novahow <[email protected]> exp with union imagespec test version 1.5.0 Signed-off-by: novahow <[email protected]> exp with union imagespec test version 1.15.0 Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
novahow
force-pushed
the
plugins/torch_async
branch
from
8fc342d to
340365e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
===========================================
+ Coverage 51.08% 92.15% +41.07%
===========================================
Files 201 33 -168
Lines 21231 1734 -19497
Branches 2731 0 -2731
===========================================
- Hits 10846 1598 -9248
+ Misses 9787 136 -9651
+ Partials 598 0 -598 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5488
Why are the changes needed?
currently I think we use torch.save and upload it to s3. As models get larger, sync saving isn't time-efficient.
What changes were proposed in this pull request?
We use futures to put it in another thread so that user can continue training. If user saves again, we wait till the prev save& upload to finish and submit the next save+upload request.
How was this patch tested?
n/a. Tried to run on local computer, but my computer was too low-end and crashed.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link