Fix FlyteDirectory on Azure
#2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Tom-Newton
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
2 tasks
pingsutw
approved these changes
Jul 5, 2024
|
Thank you @Tom-Newton |
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas Newton <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Thomas Newton <[email protected]> Signed-off-by: mao3267 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5541
Why are the changes needed?
FlyteDirectoryis broken on Azure.What changes were proposed in this pull request?
Fix
FlyteDirectoryon Azure by avoiding the need to initialise anadlfs.AzureBlobFileSystem()duringFlyteFS.extract_commonHow was this patch tested?
Added unittest coverage
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link