Improve error message for ImageSpec #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
thomasjpfan
reviewed
Jun 21, 2024
flytekit/image_spec/image_spec.py
Outdated
| click.secho("Flytekit assumes that the image already exists.", fg="blue") | ||
| return True | ||
| click.secho(f"Failed to check if the image exists with error:\n {e}", fg="red") | ||
| click.secho(f"Flytekit assumes the image {self.image_name()} already exists.", fg="blue") |
There was a problem hiding this comment.
I think this print statement belongs in should_build instead.
There was a problem hiding this comment.
That makes sense, I updated it, thanks!
flytekit/image_spec/image_spec.py
Outdated
| return True | ||
|
|
||
| click.secho(f"Failed to check if the image exists with error:\n {e}", fg="red") | ||
| click.secho(f"Flytekit assumes the image {self.image_name()} already exists.", fg="blue") |
| @@ -107,6 +107,8 @@ def is_container(self) -> bool: | |||
| def exist(self) -> bool: | |||
| """ | |||
| Check if the image exists in the registry. | |||
| Return True if the image exists in the registry, False otherwise. | |||
| Return None if failed to check if the image exists due to the permission issue or other reasons. | |||
There was a problem hiding this comment.
That Python typing for exist needs to be updated to include None.
kumare3
reviewed
Jun 21, 2024
| @@ -153,9 +158,9 @@ def exist(self) -> bool: | |||
| f" pip install --upgrade docker" | |||
| ) | |||
|
|
|||
| click.secho(f"Failed to check if the image exists with error : {e}", fg="red") | |||
| click.secho("Flytekit assumes that the image already exists.", fg="blue") | |||
There was a problem hiding this comment.
Can we ensure we handle runtime error nicely in the clean exception in pyflyte
| @@ -68,7 +80,7 @@ def execute_command(command: str): | |||
|
|
|||
| if p.returncode != 0: | |||
| _, stderr = p.communicate() | |||
| raise Exception(f"failed to run command {command} with error {stderr}") | |||
| raise Exception(f"failed to run command {command} with error:\n {stderr.decode()}") | |||
There was a problem hiding this comment.
Change this to raise assertionerror
Or runtime or specific error
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
+ Coverage 71.79% 78.14% +6.34%
==========================================
Files 182 185 +3
Lines 18561 18737 +176
Branches 3654 3662 +8
==========================================
+ Hits 13326 14642 +1316
+ Misses 4592 3471 -1121
+ Partials 643 624 -19 ☔ View full report in Codecov by Sentry. |
thomasjpfan
approved these changes
Jun 29, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: mao3267 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
To improve the error message
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Before:
After:
Related PRs
NA
Docs link
NA