Adds support for wandb backlinks through FLYTE_EXECUTION_URL #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
pingsutw
previously approved these changes
Jun 18, 2024
Signed-off-by: Thomas J. Fan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 71.79% 78.32% +6.52%
==========================================
Files 182 187 +5
Lines 18561 18880 +319
Branches 3654 3654
==========================================
+ Hits 13326 14787 +1461
+ Misses 4592 3470 -1122
+ Partials 643 623 -20 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jun 20, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…g#2497) Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Follow up to #2405
Why are the changes needed?
With this PR, a backlink is injected into the notes. This allows user to go from wandb interface back to the execution. In the wandb UI, it will end up here:
What changes were proposed in this pull request?
This PR looks for
FLYTE_EXECUTION_URLand injects it into the notes if it is available.How was this patch tested?
The unit tests were updated to check this change.