Pin numpy version in dev requirements, only register type transformer if installed #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
samhita-alla
as code owners
Signed-off-by: Niels Bantilan <[email protected]>
eapolinario
reviewed
Jun 17, 2024
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
- Coverage 73.97% 71.92% -2.06%
==========================================
Files 250 182 -68
Lines 21592 18559 -3033
Branches 3644 3653 +9
==========================================
- Hits 15973 13348 -2625
+ Misses 4973 4567 -406
+ Partials 646 644 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
…y loaded anyway Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
eapolinario
approved these changes
Jun 18, 2024
3 tasks
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
… if installed (flyteorg#2485) * remove numpy dep, conditionally register numpy type transformer Signed-off-by: Niels Bantilan <[email protected]> * pin numpy version <2 in dev requirements Signed-off-by: Niels Bantilan <[email protected]> * update numpy dep in build-with-pandas Signed-off-by: Niels Bantilan <[email protected]> * numpy matrix Signed-off-by: Niels Bantilan <[email protected]> * pin numpy<2 in onnx plugins Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * pin numpy in ci Signed-off-by: Niels Bantilan <[email protected]> * Update pythonbuild.yml * remove numpy import from top-level of types.numpy.__init__ Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * revert changes to schema and structured dataset since these are lazily loaded anyway Signed-off-by: Niels Bantilan <[email protected]> * debug Signed-off-by: Niels Bantilan <[email protected]> * numpy version pin on sqlalchemy Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
… if installed (#2485) * remove numpy dep, conditionally register numpy type transformer Signed-off-by: Niels Bantilan <[email protected]> * pin numpy version <2 in dev requirements Signed-off-by: Niels Bantilan <[email protected]> * update numpy dep in build-with-pandas Signed-off-by: Niels Bantilan <[email protected]> * numpy matrix Signed-off-by: Niels Bantilan <[email protected]> * pin numpy<2 in onnx plugins Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * pin numpy in ci Signed-off-by: Niels Bantilan <[email protected]> * Update pythonbuild.yml * remove numpy import from top-level of types.numpy.__init__ Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * revert changes to schema and structured dataset since these are lazily loaded anyway Signed-off-by: Niels Bantilan <[email protected]> * debug Signed-off-by: Niels Bantilan <[email protected]> * numpy version pin on sqlalchemy Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR on #2483.
This PR updates flytekit's imports of numpy: