Skip broken symlinks during calculation of digest (during fast registration) #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration) Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
previously approved these changes
Jun 14, 2024
| @@ -95,6 +95,9 @@ def compute_digest(source: os.PathLike, filter: Optional[callable] = None) -> st | |||
|
|
|||
| for fname in files: | |||
| abspath = os.path.join(root, fname) | |||
| # Only consider files that exist (e.g. disregard symlinks that point to non-existent files) | |||
| if not os.path.exists(abspath): | |||
There was a problem hiding this comment.
should we add an info line?
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
approved these changes
Jun 17, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…ration) (flyteorg#2482) * Skip broken symlinks during calculation of digest (during fast registration) Signed-off-by: Eduardo Apolinario <[email protected]> * Put the check back Signed-off-by: Eduardo Apolinario <[email protected]> * Add log message Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ration) (#2482) * Skip broken symlinks during calculation of digest (during fast registration) Signed-off-by: Eduardo Apolinario <[email protected]> * Put the check back Signed-off-by: Eduardo Apolinario <[email protected]> * Add log message Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We had the erroneous assumption that all files are accessible during fast registration.
What changes were proposed in this pull request?
Verify that the file exists before trying to open it.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link