Add Image builder should_build method for more customizable build behavior
#2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mizeable by builder plugin Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
samhita-alla
as code owners
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
should_build method for more customizable build behaviorshould_build method for more customizable build behavior
cosmicBboy
commented
Jun 6, 2024
There was a problem hiding this comment.
This looks good to me! @katrina mind a taking a look? context: https://unionai.slack.com/archives/C05EHTFEFB9/p1717455305121219
katrogan
approved these changes
Jun 6, 2024
pingsutw
approved these changes
Jun 6, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
…ehavior (flyteorg#2458) * add ImageSpecBuilder.should_build method to make building logic customizeable by builder plugin Signed-off-by: Niels Bantilan <[email protected]> * updates Signed-off-by: Niels Bantilan <[email protected]> * ping's update Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ehavior (#2458) * add ImageSpecBuilder.should_build method to make building logic customizeable by builder plugin Signed-off-by: Niels Bantilan <[email protected]> * updates Signed-off-by: Niels Bantilan <[email protected]> * ping's update Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Prior to this PR, the build behavior is determined by the
ImageBuildEngine. This makes the messages confusing on e.g. with the serverlessUCImageBuilder, which has different logic that determines whether an image should be built or not. The CLI messages say the images doesn't exist even when it does.What changes were proposed in this pull request?
This change introduces a
should_buildmethod to theImageSpecBuilderbase class. This method should take an image spec and output True if the image should be built or False if the image already exists.How was this patch tested?
This PR was manually tested on a Union tenant, unit tests are pending
Setup process
Screenshots
Check all the applicable boxes