Use new fileaccess to build execution state #2452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
COR-982
Why are the changes needed?
In cases where the python interpreter is not shut down between executions, we need to make sure we don't accidentally pick up an old errors.pb file.
What changes were proposed in this pull request?
When starting a new execution, we run the
setup_execution
context manager. One of the things it does is create a new execution state object, which creates a new engine dir based on the working dir. This working dir is based on the file access provider local_sandbox_dir. That local sandbox dir is created anew upon every invocation, but the new engine dir was happening before it was getting used. This PR just picks up that new workdir first, before building the execution state object.How was this patch tested?
locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link