Support Passing Dataclass Values via Command Line #2446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4486
Why are the changes needed?
Currently, we don't support
passing dataclass values via command line
after this PR.For example, using this command line will raise an error.
pyflyte run --remote --image localhost:30000/any:0528-1445 dataclass_task.py foo_wf --a '{ "x": 1, "y": "2", "z": { "1": "one", "2": "two" }, "w": [1, 2, 3] }'
What changes were proposed in this pull request?
If we use only
dataclass
decorator only for our dataclass value, convert it todataclass_json
.How was this patch tested?
local execution, remote execution and unit test.
Setup process
Screenshots
local execution
remote execution
unit test
Check all the applicable boxes