Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert jsonl to lowercase and update default image #2438

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented May 22, 2024

Tracking issue

flyteorg/flyte#5274

Why are the changes needed?

  • The blob type format should be "jsonl" as lowercase jsonl is used in the jsonl flytefile.
  • find_image_for uses the openai batch image, whereas default_image uses the flytekit image.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Samhita Alla <[email protected]>
@samhita-alla samhita-alla marked this pull request as ready for review May 22, 2024 17:33
Signed-off-by: Samhita Alla <[email protected]>
@samhita-alla samhita-alla changed the title convert jsonl to lowercase convert jsonl to lowercase and update default image May 22, 2024
@samhita-alla samhita-alla marked this pull request as draft May 22, 2024 18:02
@samhita-alla samhita-alla marked this pull request as ready for review May 22, 2024 18:06
@pingsutw pingsutw merged commit 4fcfe71 into master May 22, 2024
44 of 46 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants