Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UV install in Makefile #2421

Merged
merged 12 commits into from
May 16, 2024
Merged

Fix UV install in Makefile #2421

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7912dbb
Fix UV install in Makefile
thomasjpfan May 15, 2024
475798f
Fixes failing test
thomasjpfan May 15, 2024
926e588
Use dev version to be simplier
thomasjpfan May 15, 2024
84a2e51
Use v0.8.18 flytectl
thomasjpfan May 15, 2024
dd8efe6
Adds comment
thomasjpfan May 15, 2024
bd5cd24
Remove version specification
thomasjpfan May 16, 2024
a426ba0
Remove version pin
thomasjpfan May 16, 2024
c91c191
Use pseudo version for integreation tests
thomasjpfan May 16, 2024
33de9c3
Use a version that packaging recognizes
thomasjpfan May 16, 2024
12cf5e8
Remove quotes
thomasjpfan May 16, 2024
f6a13e0
Set flyteidl version
thomasjpfan May 16, 2024
c504943
FIX Fixes version more for uv strictness
thomasjpfan May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ setup: install-piptools ## Install requirements
# Warning: this will install the requirements in your system python
.PHONY: setup-global-uv
setup-global-uv:
uv pip install --system -r dev-requirements.in
# Use ".dev0" prefix to emulate version for dev environment
SETUPTOOLS_SCM_PRETEND_VERSION="3.0.0.dev0" uv pip install --system -r dev-requirements.in
Copy link
Collaborator

@eapolinario eapolinario May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still confused. Why are we seeing this now and not when I introduced uv in #2403?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the reason too.

And after adding SETUPTOOLS_SCM_PRETEND_VERSION, it indeed fixed my broken CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like the regression in UV. they just released yesterday. https://pypi.org/project/uv/#history

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate. I couldn't find any issue on their tracker though.


.PHONY: fmt
fmt:
Expand Down
Loading