refactor(click_types): skip serialization for default values #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
samhita-alla
approved these changes
May 15, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 21, 2024
…g#2418) Signed-off-by: Kevin Su <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
…g#2418) Signed-off-by: Kevin Su <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
…g#2418) Signed-off-by: Kevin Su <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Default workflow inputs are serialized twice in the flytekit
flytekit/flytekit/interaction/click_types.py
Line 389 in 6d881a8
flytekit/flytekit/core/interface.py
Line 243 in 93f690c
What changes were proposed in this pull request?
Skip serialization if the input matches the default value in the launch plan.
How was this patch tested?
pyflyte run&pyflyte run --remote ...Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA