fix(ImageSpec): Ensure all APIErrors return a value

[pingsutw]

Tracking issue

NA

Why are the changes needed?

image.exists() return None when the docker client raises an error & the error code is not 404

What changes were proposed in this pull request?

Always return true if error code is not 404

How was this patch tested?

local sandbox

Setup process

from flytekit import ImageSpec, task, dynamic


new_flytekit = "git+https://github.com/flyteorg/flytekit.git@285148f1189cd1b14503b50caf60ba63222272e9"

repro_img = ImageSpec(
    name="flytekit",
    base_image="ghcr.io/flyteorg/flytekit:py3.11-latest",
    builder="envd",
    packages=[new_flytekit],
    apt_packages=["curl", "git"],
    registry="localhost:30000",
)


@task(container_image=repro_img)
def foo():
    print("foo")


@dynamic(container_image=repro_img)
def bar():
    foo()


if __name__ == "__main__":
    print("image", repro_img.exist())

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.85%. Comparing base (4dd4d22) to head (702c8ac).
Report is 5 commits behind head on master.

Files	Patch %	Lines
flytekit/image_spec/image_spec.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   75.81%   75.85%   +0.03%     
==========================================
  Files         181      181              
  Lines       18327    18390      +63     
  Branches     2580     3599    +1019     
==========================================
+ Hits        13895    13949      +54     
- Misses       3830     3839       +9     
  Partials      602      602              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.