fix(import): Fix relative import path error #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
May 9, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
N/A
Why are the changes needed?
Running
pyflyte run examples/basics/basics/documenting_workflows.pyin theflytesnacksrepo raises error.What changes were proposed in this pull request?
Because
documenting_workflows.pyhas relative imports in it, theadditional_pathshould be its parent folder's parent folder.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link