refactor(import): Remove meaningless underscore imports #2375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
N/A
Why are the changes needed?
There are many
import pkg as _pkg
patterns in the codebase, and many of them are meaningless. For example, there are some files containing the following weird code snippetflytekit/flytekit/clis/flyte_cli/main.py
Lines 3 to 4 in f1689b7
which imports the
os
package twice.Based on my own inference, perhaps the predecessors wanted to prevent exporting package names. However, renaming the builtin packages is meaningless.
What changes were proposed in this pull request?
This PR only deals with the
import pkg as _pkg
case. There are still many cases but refactoring them may introduce some unexpected behaviors. One can find these cases by searchingas _
string in the codebase.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link