Adds custom string format parameter to customize ImageSpec's tag #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:S
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
changed the title
pingsutw
previously approved these changes
Apr 14, 2024
Signed-off-by: Thomas J. Fan <[email protected]>
eapolinario
reviewed
Apr 19, 2024
Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
force-pushed
the
imagespec-tag-modifier
branch
from
702fd48 to
e528fee
Compare
pingsutw
approved these changes
Apr 30, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 9, 2024
…teorg#2349) Signed-off-by: Thomas J. Fan <[email protected]> Co-authored-by: Kevin Su <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
…teorg#2349) Signed-off-by: Thomas J. Fan <[email protected]> Co-authored-by: Kevin Su <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR allows users to generate any tag they want for their images. This is useful for teams that want to have custom names for managing their docker images.
What changes were proposed in this pull request?
This PR adds a
tag_formattoImageSpecwhich accepts a format string to custom the image's tag.How was this patch tested?
I added a unit test to check the new behavior.