Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageSpec reference docs to flyte docs #2347

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 12, 2024

What changes were proposed in this pull request?

Adds changes needed to add ImageSpec reference docs to the Flyte docs site.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TK

@neverett neverett self-assigned this Apr 12, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.62%. Comparing base (bf38b8e) to head (97c25ed).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2347      +/-   ##
==========================================
- Coverage   83.04%   79.62%   -3.43%     
==========================================
  Files         324      220     -104     
  Lines       24861    20359    -4502     
  Branches     3547     3554       +7     
==========================================
- Hits        20645    16210    -4435     
+ Misses       3591     3521      -70     
- Partials      625      628       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett requested a review from ppiegaze April 12, 2024 20:03
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Apr 12, 2024
@neverett neverett merged commit 87bbbb4 into master Apr 12, 2024
48 of 49 checks passed
@neverett neverett deleted the nikki/imagespec-docs-visible branch April 12, 2024 20:19
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants