Add identity to task execution metadata #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2315 +/- ##
===========================================
- Coverage 83.50% 46.81% -36.70%
===========================================
Files 324 219 -105
Lines 24672 20272 -4400
Branches 3512 3600 +88
===========================================
- Hits 20603 9490 -11113
- Misses 3438 10694 +7256
+ Partials 631 88 -543 ☔ View full report in Codecov by Sentry. |
noahjax
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:S
noahjax
commented
Apr 3, 2024
eapolinario
previously approved these changes
Apr 8, 2024
|
@eapolinario with the 1.12 beta release cut, can this be merged now? |
ddl-ebrown
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 4, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. Signed-off-by: noahjax <[email protected]>
ddl-ebrown
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 4, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. - This PR is based on upstream tag v1.12.0b7 Signed-off-by: noahjax <[email protected]>
3 tasks
|
@noahjax , now that flyteidl 1.12.0 is out, can you set it as the lower bound in pyproject.toml? |
|
I recently left Domino and it seems that I have lost push access to repos in the |
|
Can do - will work to get this one in tomorrow. Thanks! |
Signed-off-by: noahjax <[email protected]> Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: noahjax <[email protected]> Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: noahjax <[email protected]> Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
ddl-rliu
force-pushed
the
noahjax.add-identity-to-metadata
branch
from
a1ba33e to
bc1efd9
Compare
ddl-ebrown
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 16, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. - This PR is based on upstream tag v1.12.0b7 Signed-off-by: noahjax <[email protected]>
ddl-ebrown
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 16, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. - This PR is based on upstream tag v1.12.0b7 Signed-off-by: noahjax <[email protected]>
ddl-rliu
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 23, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. - This PR is based on upstream tag v1.12.0b7 Signed-off-by: noahjax <[email protected]>
ddl-rliu
pushed a commit
to dominodatalab/flytekit
that referenced
this pull request
May 23, 2024
- This is necessary due to a pending PR to upstream flytekit: flyteorg#2315 This PR hasn't been merged because a new flyteidl release had to be cut. Upstream flyteorg/flyte produce a new v1.12.0-b0 tag / release that includes the necessary flyteidl changes that can now be referenced https://github.com/flyteorg/flyte/releases/tag/v1.12.0-b0 - Once the flytekit PR merges, this custom tag / version of flytekit that we've forked will no longer be necessary - NOTE: the reference to flyteidl may not be consumed properly as a "child" transitive dependency. For instance, pip install may work, while pip install may not - depending on the toolchain involved. - This PR is based on upstream tag v1.12.0b7 Signed-off-by: noahjax <[email protected]>
pingsutw
approved these changes
Jun 14, 2024
|
YES - thanks @pingsutw ! |
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: noahjax <[email protected]> Signed-off-by: ddl-rliu <[email protected]> Co-authored-by: ddl-rliu <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: noahjax <[email protected]> Signed-off-by: ddl-rliu <[email protected]> Co-authored-by: ddl-rliu <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
For our specific use case it is critical to be able to determine the identity for the subject who launches a task.
What changes were proposed in this pull request?
Add identity to TaskExecutionMetadata. This builds on top of #2282, and relies on flyteorg/flyte#5105 to add identity to the flyteidl TaskExecutionMetadata.
How was this patch tested?