Add way to create FlyteFile/Directory from remote location #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
+ Coverage 83.40% 83.47% +0.07%
==========================================
Files 316 324 +8
Lines 24457 24741 +284
Branches 3517 3521 +4
==========================================
+ Hits 20398 20653 +255
- Misses 3427 3454 +27
- Partials 632 634 +2 ☔ View full report in Codecov by Sentry. |
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:M
eapolinario
approved these changes
Mar 29, 2024
wild-endeavor
changed the title
wild-endeavor
changed the title
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Add a couple of class methods ``` def from_source(cls, source: str | os.PathLike) -> FlyteFile def from_source(cls, source: str | os.PathLike) -> FlyteDirectory ``` meant to be used with remote paths. This is because if you create a file with an s3/gs link as the path using the normal constructor, it doesn't come with a download function, forcing users to manually call into the data persistence layer manually. Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Add a couple of class methods
meant to be used with remote paths. This is because if you create a file with an s3/gs link as the path using the normal constructor, it doesn't come with a download function, forcing users to manually call into the data persistence layer manually.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link