-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Improve task module extraction logic #2290
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2290 +/- ##
==========================================
- Coverage 83.12% 83.09% -0.03%
==========================================
Files 324 324
Lines 24779 24789 +10
Branches 3523 3524 +1
==========================================
+ Hits 20597 20599 +2
- Misses 3558 3565 +7
- Partials 624 625 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test again
@@ -788,6 +792,14 @@ def register_task( | |||
:param version: version that will be used to register. If not specified will default to using the serialization settings default | |||
:return: | |||
""" | |||
if serialization_settings is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment here explaining when this situation is relevant? and maybe also a comment in tracker.py explaining when the second element in the return tuple (the thing that used to be "") is relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Kevin Su <[email protected]>
8512bc6
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Tracking issue
NA
Why are the changes needed?
Cannot run a task registered by flytekit remote
What changes were proposed in this pull request?
SerializationSettings
optionalBefore:
After:
How was this patch tested?
remote cluster
Setup process
Screenshots
Related PRs
NA
Docs link
NA