Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Databricks Agent Phase #2244

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Mar 6, 2024

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

To support more phases in the databricks agent.
At before, we only have RUNNING and terminal phase, which doesn't provide good user experience to users.

What changes were proposed in this pull request?

  1. fix bug in bigquery agent
  2. Implement the databricks plugin's Status function's logic to decide databricks agent's phase.
    databricks plugin implementation: https://github.com/flyteorg/flyte/blob/master/flyteplugins/go/tasks/plugins/webapi/databricks/plugin.go#L251-L283

How was this patch tested?

  1. Unit tests
  2. return Initializing Phase, messages and logs to flytepropeller, show messages in the flyteconsole.

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#1797

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.99%. Comparing base (1c0b228) to head (7bfd8f5).
Report is 8 commits behind head on master.

Files Patch % Lines
...gins/flytekit-spark/flytekitplugins/spark/agent.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
- Coverage   85.99%   85.99%   -0.01%     
==========================================
  Files         320      322       +2     
  Lines       24250    24371     +121     
  Branches     3667     3690      +23     
==========================================
+ Hits        20854    20958     +104     
- Misses       2745     2756      +11     
- Partials      651      657       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier changed the title Switching Databricks Agent Phase from Running to Initializing Refactor Databricks Agent Phase Mar 6, 2024
@Future-Outlier Future-Outlier marked this pull request as draft March 6, 2024 09:23
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier

This comment was marked as outdated.

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier self-assigned this Mar 8, 2024
@Future-Outlier Future-Outlier marked this pull request as ready for review March 8, 2024 07:40
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 10, 2024
@pingsutw pingsutw merged commit d1baacc into master Mar 10, 2024
92 checks passed
austin362667 pushed a commit to austin362667/flytekit that referenced this pull request Mar 16, 2024
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants