-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Databricks Agent Phase #2244
Merged
pingsutw
merged 4 commits into
master
from
change-databricks-running-phase-to-intializing
Mar 10, 2024
Merged
Refactor Databricks Agent Phase #2244
pingsutw
merged 4 commits into
master
from
change-databricks-running-phase-to-intializing
Mar 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
March 6, 2024 08:39
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Mar 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
==========================================
- Coverage 85.99% 85.99% -0.01%
==========================================
Files 320 322 +2
Lines 24250 24371 +121
Branches 3667 3690 +23
==========================================
+ Hits 20854 20958 +104
- Misses 2745 2756 +11
- Partials 651 657 +6 ☔ View full report in Codecov by Sentry. |
Future-Outlier
changed the title
Switching Databricks Agent Phase from Running to Initializing
Refactor Databricks Agent Phase
Mar 6, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
pingsutw
reviewed
Mar 6, 2024
Signed-off-by: Future-Outlier <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Mar 8, 2024
pingsutw
approved these changes
Mar 10, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Future-Outlier <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
To support more phases in the databricks agent.
At before, we only have
RUNNING
and terminal phase, which doesn't provide good user experience to users.What changes were proposed in this pull request?
Status
function's logic to decide databricks agent's phase.databricks plugin implementation: https://github.com/flyteorg/flyte/blob/master/flyteplugins/go/tasks/plugins/webapi/databricks/plugin.go#L251-L283
How was this patch tested?
Initializing
Phase, messages and logs to flytepropeller, show messages in the flyteconsole.Screenshots
Check all the applicable boxes
Related PRs
#1797