ShellTask: stores process return code, stdout and stderr for later use. #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoistlaurent
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2229 +/- ##
==========================================
+ Coverage 84.74% 85.98% +1.24%
==========================================
Files 315 320 +5
Lines 24142 24255 +113
Branches 3666 3668 +2
==========================================
+ Hits 20458 20855 +397
+ Misses 3025 2748 -277
+ Partials 659 652 -7 ☔ View full report in Codecov by Sentry. |
Fixes #4888. Signed-off-by: Benoist LAURENT <[email protected]>
Signed-off-by: Benoist LAURENT <[email protected]>
pingsutw
approved these changes
Mar 10, 2024
|
Congrats on merging your first pull request! 🎉 |
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Mar 16, 2024
…e. (flyteorg#2229) Signed-off-by: Benoist LAURENT <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…e. (#2229) Signed-off-by: Benoist LAURENT <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4888.
Tracking issue
flyteorg/flyte#4888
followed by @eapolinario
Why are the changes needed?
What changes were proposed in this pull request?
ProcessResultto store a subprocess return code, stdout and stderrProcessResultinstead ofTuple[str, str]ShellTaskstores an instance ofProcessResultHow was this patch tested?
./tests/flytekit/unit/extras/tasks/test_shell.py:test_shell_task_access_to_resultaddedtest_subproc_execute()adapted to accommodatesubproc_executenew return typeI updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.