Move agent (extend) tests to extras #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2218 +/- ##
==========================================
- Coverage 85.83% 83.74% -2.09%
==========================================
Files 314 292 -22
Lines 24027 22919 -1108
Branches 3641 3641
==========================================
- Hits 20623 19194 -1429
- Misses 2762 3110 +348
+ Partials 642 615 -27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
3 tasks
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
eapolinario
approved these changes
Feb 27, 2024
pingsutw
approved these changes
Feb 27, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* only pre for idl Signed-off-by: Yee Hing Tong <[email protected]> * more Signed-off-by: Yee Hing Tong <[email protected]> * add extend to extras Signed-off-by: Yee Hing Tong <[email protected]> * remove echo Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
extend/to the extras make target. These tests are currently failing (and correctly so) because of backwards-incompatible changes being made to alpha portions of the idl (agent api). The plugin failures are also related to that change. The code and relevant tests will be fixed soon.