-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(flyteinteractive): Change docker build to docker buildx build #2200
docs(flyteinteractive): Change docker build to docker buildx build #2200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about use docker buildx build
instead of docker build
?
It seems that docker build
will be deprecated in the future, we will not need to update the doc again in the future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
- Coverage 85.53% 85.46% -0.07%
==========================================
Files 309 305 -4
Lines 23460 23317 -143
Branches 3630 3630
==========================================
- Hits 20066 19928 -138
+ Misses 2752 2746 -6
- Partials 642 643 +1 ☔ View full report in Codecov by Sentry. |
… build command Resolves: flyteorg/flyte#4918 Signed-off-by: Chi-Sheng Liu <[email protected]>
9fd5c08
to
fad555b
Compare
The move to |
… build command (#2200) Resolves: flyteorg/flyte#4918 Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Tracking issue
flyteorg/flyte#4918
Why are the changes needed?
There is no
--push
flag for thedocker build
command in Linux machine.What changes were proposed in this pull request?
Change
docker build
todocker buildx build
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link