Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flyteinteractive): Change docker build to docker buildx build #2200

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Feb 19, 2024

Tracking issue

flyteorg/flyte#4918

Why are the changes needed?

There is no --push flag for the docker build command in Linux machine.

What changes were proposed in this pull request?

Change docker build to docker buildx build

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 19, 2024
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about use docker buildx build instead of docker build?
It seems that docker build will be deprecated in the future, we will not need to update the doc again in the future.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7794d3a) 85.53% compared to head (fad555b) 85.46%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2200      +/-   ##
==========================================
- Coverage   85.53%   85.46%   -0.07%     
==========================================
  Files         309      305       -4     
  Lines       23460    23317     -143     
  Branches     3630     3630              
==========================================
- Hits        20066    19928     -138     
+ Misses       2752     2746       -6     
- Partials      642      643       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MortalHappiness MortalHappiness force-pushed the docs/#4918-docker-build-no-push-flag branch from 9fd5c08 to fad555b Compare February 20, 2024 09:59
@MortalHappiness MortalHappiness changed the title docs(flyteinteractive): Remove the invalid --push flag for the docker build command docs(flyteinteractive): Change docker build to docker buildx build Feb 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Feb 20, 2024
@eapolinario
Copy link
Collaborator

The move to buildx requires a builder to be defined, but the error will be apparent to the user (i.e. it will say something along the lines of a builder being needed), so no need to mention it in the docs.

@eapolinario eapolinario merged commit 7a3c265 into flyteorg:master Feb 20, 2024
80 of 83 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
… build command (#2200)

Resolves: flyteorg/flyte#4918

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants