Fix airflow sensor #2169
Merged
Fix airflow sensor #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
- Coverage 85.66% 83.69% -1.97%
==========================================
Files 314 288 -26
Lines 23980 22765 -1215
Branches 3627 3627
==========================================
- Hits 20543 19054 -1489
- Misses 2800 3106 +306
+ Partials 637 605 -32 ☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Feb 7, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
eapolinario
approved these changes
Feb 9, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
The airflow sensor is running in the pod, which is wrong.
What changes were proposed in this pull request?
Translate airflow sensor to AirflowTask instead of AirflowContainerTask
How was this patch tested?
local/cloud
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA