Artf/cleanup #2158
Merged
Artf/cleanup #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## artifacts #2158 +/- ##
=============================================
+ Coverage 81.67% 85.69% +4.02%
=============================================
Files 314 314
Lines 23825 23957 +132
Branches 3591 3623 +32
=============================================
+ Hits 19458 20531 +1073
+ Misses 3768 2792 -976
- Partials 599 634 +35 ☔ View full report in Codecov by Sentry. |
eapolinario
added a commit
that referenced
this pull request
Feb 8, 2024
* temp Signed-off-by: Yee Hing Tong <[email protected]> * stuff Signed-off-by: Yee Hing Tong <[email protected]> * temp Signed-off-by: Yee Hing Tong <[email protected]> * scaffolding areas mostly identified Signed-off-by: Yee Hing Tong <[email protected]> * add artifact to upload request Signed-off-by: Yee Hing Tong <[email protected]> * remove an unnecessary line in workflow Signed-off-by: Yee Hing Tong <[email protected]> * finish adding examples use cases maybe Signed-off-by: Yee Hing Tong <[email protected]> * add project/dom to get query Signed-off-by: Yee Hing Tong <[email protected]> * add from flyte idl Signed-off-by: Yee Hing Tong <[email protected]> * add project domain to as query Signed-off-by: Yee Hing Tong <[email protected]> * add condition in parameter to flyte idl Signed-off-by: Yee Hing Tong <[email protected]> * test stuff * Remove artifactID from literal oneof, add to metadata (#2) * Triggers (#6) * Minor changes to get time series example working #8 Signed-off-by: Yee Hing Tong <[email protected]> * switch channel (#10) Signed-off-by: Yee Hing Tong <[email protected]> * fix tests ignore - pr into other pr (#1858) Signed-off-by: Yee Hing Tong <[email protected]> * Artf/update idl ux (#1920) Signed-off-by: Yee Hing Tong <[email protected]> * Artf/trigger (#1948) * Add triggers * Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now. Signed-off-by: Yee Hing Tong <[email protected]> * remove the now deleted artifact spec (#1984) Signed-off-by: Yee Hing Tong <[email protected]> * Literal metadata model update (#2089) Signed-off-by: Yee Hing Tong <[email protected]> * Separate time partition (#2114) Signed-off-by: Yee Hing Tong <[email protected]> * Split service code (#2136) Signed-off-by: Yee Hing Tong <[email protected]> * remove empty files Signed-off-by: Yee Hing Tong <[email protected]> * add noneness check to metadata and add test Signed-off-by: Yee Hing Tong <[email protected]> * remove sandbox test for now Signed-off-by: Yee Hing Tong <[email protected]> * Artf/cleanup (#2158) * add a test Signed-off-by: Yee Hing Tong <[email protected]> * try updates Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> * Use python 3.9 to run make doc-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * reasons not msg Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Feb 8, 2024
* temp Signed-off-by: Yee Hing Tong <[email protected]> * stuff Signed-off-by: Yee Hing Tong <[email protected]> * temp Signed-off-by: Yee Hing Tong <[email protected]> * scaffolding areas mostly identified Signed-off-by: Yee Hing Tong <[email protected]> * add artifact to upload request Signed-off-by: Yee Hing Tong <[email protected]> * remove an unnecessary line in workflow Signed-off-by: Yee Hing Tong <[email protected]> * finish adding examples use cases maybe Signed-off-by: Yee Hing Tong <[email protected]> * add project/dom to get query Signed-off-by: Yee Hing Tong <[email protected]> * add from flyte idl Signed-off-by: Yee Hing Tong <[email protected]> * add project domain to as query Signed-off-by: Yee Hing Tong <[email protected]> * add condition in parameter to flyte idl Signed-off-by: Yee Hing Tong <[email protected]> * test stuff * Remove artifactID from literal oneof, add to metadata (#2) * Triggers (#6) * Minor changes to get time series example working #8 Signed-off-by: Yee Hing Tong <[email protected]> * switch channel (#10) Signed-off-by: Yee Hing Tong <[email protected]> * fix tests ignore - pr into other pr (#1858) Signed-off-by: Yee Hing Tong <[email protected]> * Artf/update idl ux (#1920) Signed-off-by: Yee Hing Tong <[email protected]> * Artf/trigger (#1948) * Add triggers * Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now. Signed-off-by: Yee Hing Tong <[email protected]> * remove the now deleted artifact spec (#1984) Signed-off-by: Yee Hing Tong <[email protected]> * Literal metadata model update (#2089) Signed-off-by: Yee Hing Tong <[email protected]> * Separate time partition (#2114) Signed-off-by: Yee Hing Tong <[email protected]> * Split service code (#2136) Signed-off-by: Yee Hing Tong <[email protected]> * remove empty files Signed-off-by: Yee Hing Tong <[email protected]> * add noneness check to metadata and add test Signed-off-by: Yee Hing Tong <[email protected]> * remove sandbox test for now Signed-off-by: Yee Hing Tong <[email protected]> * Artf/cleanup (#2158) * add a test Signed-off-by: Yee Hing Tong <[email protected]> * try updates Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> * Use python 3.9 to run make doc-requirements.txt Signed-off-by: Eduardo Apolinario <[email protected]> * reasons not msg Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.